Dayo Posted January 7, 2014 Share Posted January 7, 2014 I have got gangster legends V2 to the point where people can start testing what i have made so far. I have made a repository on github for the script and it can be found here. Over the past few days i have made several changes to the script so if you have an old copy re-download it ;) If you have any suggestions/criticisms feel free to post them below, PM me or email me. 1 Quote Link to comment Share on other sites More sharing options...
Guest Posted January 7, 2014 Share Posted January 7, 2014 Epic stuff. Looking forward to the changes :). Sticky thread? Quote Link to comment Share on other sites More sharing options...
Dayo Posted January 7, 2014 Author Share Posted January 7, 2014 Thanks, your suggestions have been top notch so far :D btw i implemented the methodData and method_{actionName}, makes the code much neater rather then having a load of global variables everywhere :P I still have to implement the validation on the moduleData, not sure how i am going to handle it when it doesn't validate maybe show an error and kill the module from running Quote Link to comment Share on other sites More sharing options...
Guest Posted January 7, 2014 Share Posted January 7, 2014 Thanks, your suggestions have been top notch so far :D btw i implemented the methodData and method_{actionName}, makes the code much neater rather then having a load of global variables everywhere :P I still have to implement the validation on the moduleData, not sure how i am going to handle it when it doesn't validate maybe show an error and kill the module from running Good stuff, stuck the thread for you as well :) Quote Link to comment Share on other sites More sharing options...
john. Posted January 7, 2014 Share Posted January 7, 2014 Congratulations on your release The Indentation looks bad If you look at: https://github.com/ChristopherDay/Gangster-Legends-V2/blob/master/class/page.php (Do you use tabs?) There are some features lacking that I find essential that you should consider implementing sometime: Proper error handling & logging What happens if the database cannot connect? Depending on the server it may throw an exception or warning, this need to be handled accordingly, If I am in a debug mode (writing features to the game) I would like to have as much information as possible, however during production (when players are playing the game) I wouldn't want any potential harmful information to be shown. You should add a Error handler that logs appropriately, taking the criteria of development or production in consideration and act there after. Quote Link to comment Share on other sites More sharing options...
Djkanna Posted January 7, 2014 Share Posted January 7, 2014 Congratulations on the release, looking forward to how it progresses. Quote Link to comment Share on other sites More sharing options...
Dayo Posted January 8, 2014 Author Share Posted January 8, 2014 Congratulations on your release The Indentation looks bad If you look at: https://github.com/ChristopherDay/Gangster-Legends-V2/blob/master/class/page.php (Do you use tabs?) There are some features lacking that I find essential that you should consider implementing sometime: Proper error handling & logging What happens if the database cannot connect? Depending on the server it may throw an exception or warning, this need to be handled accordingly, If I am in a debug mode (writing features to the game) I would like to have as much information as possible, however during production (when players are playing the game) I wouldn't want any potential harmful information to be shown. You should add a Error handler that logs appropriately, taking the criteria of development or production in consideration and act there after. You are correct, i have been working on getting other areas working, i shall work on this next and will hopefuly have something today. As for the indentation, im not sure why it is messed up as locally the indentation is fine, i shall go through it again and re-do it it may be due to me using diffrent versions of brackets on different computers :) Quote Link to comment Share on other sites More sharing options...
Dayo Posted January 9, 2014 Author Share Posted January 9, 2014 Last commit i made i added a basic error handler displaying errors can be turned off/on from config.php, all errors have two possible severities minor (wont affect the page load) and major (breaks php completely) the error is then logged as JSON array in a .txt file that will be viewable at a later date in the admin panel :) Quote Link to comment Share on other sites More sharing options...
sniko Posted January 9, 2014 Share Posted January 9, 2014 Your branching model is non-existent :/ Please adopt something like this! (It'll help with development!) Quote Link to comment Share on other sites More sharing options...
Dayo Posted January 11, 2014 Author Share Posted January 11, 2014 (edited) After leaving my laptop at home thursday and going to the pub friday i now have time to do some more work on GL V2 tasks for today are: 1) Look at a branching model for Github as its currently non existent - Done 2) Finish error handeling - Done 3) Make a menu system so modules can have a menu link without the user having to edit html code 4) Move the demo to a decent domain - done (http://gangsterlegends.co.uk/) 5) Start work on the back end of the admin panel (I have left all the GUI at work) Edited January 12, 2014 by Dayo Quote Link to comment Share on other sites More sharing options...
CENilsen Posted January 11, 2014 Share Posted January 11, 2014 Looking forward to it :) Quote Link to comment Share on other sites More sharing options...
Canjucks Posted May 26, 2020 Share Posted May 26, 2020 I love what you have done with this engine. Personally I'm trying to re-learn coding again to use as a platform for my R/L job. It would be nice to learn again and have motivation for it. A very long time I looked at mccodes on a friends game. I did some coding for that but that was largely crap code, worked but crap code knew it at the time lol Now with GL I hope to fix that and do it properly. 1 Quote Link to comment Share on other sites More sharing options...
Sim Posted June 10, 2020 Share Posted June 10, 2020 @Tingle you can download it here. It's the link in first post. I'm not really sure where the actual download button is on GitHub but @Dayoor someone should add the latest release on the market place Quote Link to comment Share on other sites More sharing options...
Dayo Posted June 10, 2020 Author Share Posted June 10, 2020 It is already on the market place here https://makewebgames.io/files/category/3-gangster-legends-v2/ 2 Quote Link to comment Share on other sites More sharing options...
Sim Posted December 15, 2020 Share Posted December 15, 2020 Can you update the download link on the marketplace? I cant find the download link on the github page. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.