peterisgb Posted September 23, 2015 Share Posted September 23, 2015 I don't really post here much, not as much as i should. This is a mod i have been working on, with some help for a while now, it could be better and would love to see what users do with it. Please do post back feedback and your updates. :D. This is a Map system, you can travel around the map, attack other players, find stuff, go to towns, buy a house within a town, upgrade your house, do missions and plans for more. Here goes, move.php You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. movetown1.php You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. And of course the php stuff You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. Also you need to create 6 new fields into the users locationx int 11 default 0 locationy int 11 default 0 moves int 11 default 50 (or whatever else you choose, you'll need to insert this into the cron line.). maxmoves int(11) 50 locationxt int(11) 10 locationyt int(11) 10 and i think at last but not least, the images, sorry the images ain't good but i'm not very good and pics. At least this is one idea thats never been done before. mapimageback.zip 1 Quote Link to comment Share on other sites More sharing options...
~Rob0t Posted September 23, 2015 Share Posted September 23, 2015 (edited) <font> is deprecated Why inline styling? Use classes/ids and make the free system more adaptable to your audience Why so many $locationx and $locationy if() statements? Use array logic for this! Constants defined in the middle of the script - ew. Functions that echo HTML... ew. Staff actions have no real indenting - it's hard to read. Staff actions are vulnerable to SQL injection. Hardcoded cost values... ew. Where's the classes? The extendibility? The awesome?! Though, great attempt but please read and consider the above - if you need any assistance with of the points, Slack me. Edited September 23, 2015 by ~Rob0t Quote Link to comment Share on other sites More sharing options...
Coly010 Posted September 23, 2015 Share Posted September 23, 2015 If you redo your code taking into consideration what [MENTION=71587]~Rob0t[/MENTION] said then the code and mod will be much better :) but it is a good attempt :! Quote Link to comment Share on other sites More sharing options...
peterisgb Posted September 23, 2015 Author Share Posted September 23, 2015 Nice, Well this is a preview of what has been done so far, feel free to update this, secure it and repost your work back here, as i said its a big project and its alot to do on my own, specially when i aint a great coder and havent really been coding for the last few years. Quote Link to comment Share on other sites More sharing options...
crimec Posted September 23, 2015 Share Posted September 23, 2015 I don't really post here much, not as much as i should. This is a mod i have been working on, with some help for a while now, it could be better and would love to see what users do with it. Please do post back feedback and your updates. :D. This is a Map system, you can travel around the map, attack other players, find stuff, go to towns, buy a house within a town, upgrade your house, do missions and plans for more. Here goes, move.php You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. movetown1.php You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. And of course the php stuff You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. Also you need to create 3 new fields into the users locationx int 11 default 0 locationy int 11 default 0 moves int 11 default 50 (or whatever else you choose, you'll need to insert this into the cron line.). and i think at last but not least, the images, sorry the images ain't good but i'm not very good and pics. At least this is one idea thats never been done before. Ewwww, so many unnecessary if statements, and it's hardcoded in some areas and you ain't even escaping your queries or sanitizing your POSTS but nice attempt 1 Quote Link to comment Share on other sites More sharing options...
Veramys Posted September 24, 2015 Share Posted September 24, 2015 (edited) I love you [MENTION=50378]Guest[/MENTION]. You must spread some Reputation around before giving it to Guest again. Peter you should think about optimizing the database stuff. You don't need everything to be int 11 Edited September 24, 2015 by Veramis Quote Link to comment Share on other sites More sharing options...
peterisgb Posted September 24, 2015 Author Share Posted September 24, 2015 (edited) guys bug off with this lol. This thread is about my rubbish code with great ideas and potential, All comments about my map system please. Also if any of you have used this please post your updates here and i want this to be a communal project. Edited September 24, 2015 by peterisgb 1 Quote Link to comment Share on other sites More sharing options...
SRB Posted September 25, 2015 Share Posted September 25, 2015 Ewwww, so many unnecessary if statements, and it's hardcoded in some areas and you ain't even escaping your queries or sanitizing your POSTS but nice attempt So, let me get this right - everybody elses crappy comments get deleted, but the biggest cawk comment on here remains? Yeah, I get that.... Quote Link to comment Share on other sites More sharing options...
KyleMassacre Posted September 25, 2015 Share Posted September 25, 2015 In my defense I didn't feel it was that bad of a post. Could it have been better? Yes. But he did say there is a better approach to having so many if()s although he didn't say what was better. And I just thought it was sort of constructive but it was on topic for the most part. I did realize I went crazy and deleted [MENTION=68961]Veramis[/MENTION] post and that was my fault, it did contribute so I will fix that. Quote Link to comment Share on other sites More sharing options...
peterisgb Posted September 25, 2015 Author Share Posted September 25, 2015 I am kinda hoping that because this is such a great mod and idea that someone might clean it up and post it back here to share, i've done most of the hardwork, as its now free, input and peoples changes and ideas posted backk :D 1 Quote Link to comment Share on other sites More sharing options...
peterisgb Posted September 25, 2015 Author Share Posted September 25, 2015 I love you [MENTION=50378]Guest[/MENTION]. You must spread some Reputation around before giving it to Guest again. Peter you should think about optimizing the database stuff. You don't need everything to be int 11 Optimizing the database stuff, explain, alot has changed since i left. Ewwww, so many unnecessary if statements, and it's hardcoded in some areas and you ain't even escaping your queries or sanitizing your POSTS but nice attempt ty for the nice attempt, so with the unnecessary if statements, what should of do instead? <font> is deprecated Why inline styling? Use classes/ids and make the free system more adaptable to your audience Why so many $locationx and $locationy if() statements? Use array logic for this! Constants defined in the middle of the script - ew. Functions that echo HTML... ew. Staff actions have no real indenting - it's hard to read. Staff actions are vulnerable to SQL injection. Hardcoded cost values... ew. Where's the classes? The extendibility? The awesome?! Though, great attempt but please read and consider the above What do you mean by inline styling? I don't know how to properly do array logic, it confuses me and i get stuck, What do you mean constant defined in the middle of the script. functions that echo HTML, how else do i print something? print "? Yeah the staff options was abit rushed, That was the last thing i was working on before posting it up, Protection against staff SQL injections lol, ouch yeah i know, I've never quite got the hang of how to "secure stuff" reason why i don't run a game, just make crap lol. "Where's the classes? The extendibility? The awesome?!" explain, what awsome? the map is awsome and you can move around it and go into town and buy a house lol. Quote Link to comment Share on other sites More sharing options...
peterisgb Posted October 9, 2015 Author Share Posted October 9, 2015 so anyone done some work and chucked this on their game?. post link would love to see. 1 Quote Link to comment Share on other sites More sharing options...
peterisgb Posted January 9, 2016 Author Share Posted January 9, 2016 No-one has worked on this? 1 Quote Link to comment Share on other sites More sharing options...
boionfire81 Posted March 14, 2016 Share Posted March 14, 2016 Any updates? Quote Link to comment Share on other sites More sharing options...
peterisgb Posted May 15, 2023 Author Share Posted May 15, 2023 On 3/14/2016 at 2:32 PM, boionfire81 said: Any updates? Negative. It was a mini project that never went anywhere. so i stopped in 2016. Quote Link to comment Share on other sites More sharing options...
ags_cs4 Posted May 16, 2023 Share Posted May 16, 2023 (edited) The idea is great, it can be used on a JRPG game I might use the idea on my fantasy-RPG game, I got already 2D assets for castels, houses, decoration and materials just need to finish all the project i got on hand 🤣 I might try it today after i finish a module im working on Edited May 16, 2023 by ags_cs4 Quote Link to comment Share on other sites More sharing options...
peterisgb Posted May 16, 2023 Author Share Posted May 16, 2023 6 hours ago, ags_cs4 said: The idea is great, it can be used on a JRPG game I might use the idea on my fantasy-RPG game, I got already 2D assets for castels, houses, decoration and materials just need to finish all the project i got on hand 🤣 I might try it today after i finish a module im working on This was before i really learnt arrays, Still not great arrays but had i know how to do arrays this wouldnt be half as long as it is. I'd suggest to array most of this before working on it. Quote Link to comment Share on other sites More sharing options...
ags_cs4 Posted May 16, 2023 Share Posted May 16, 2023 yeah that goes without saying, plus lot of optimization on the db side, will need to read the code more to see what need to be remade but so far its a gread idea tbh how did i miss this gem 🤣 Quote Link to comment Share on other sites More sharing options...
peterisgb Posted May 16, 2023 Author Share Posted May 16, 2023 1 hour ago, ags_cs4 said: yeah that goes without saying, plus lot of optimization on the db side, will need to read the code more to see what need to be remade but so far its a gread idea tbh how did i miss this gem 🤣 hehe, After i got this far it didnt quite fit into the game i was running at the time so i posted it here instead of just binning it as it was too much of a good idea just to throw it away, specially after all the work put into it. Quote Link to comment Share on other sites More sharing options...
ags_cs4 Posted May 16, 2023 Share Posted May 16, 2023 (edited) @peterisgb i like the idea i did work on a system for a map with locations/cities (circles) and quests (scrolls), chests the game need lot of thinking than any normal browser game as i want the game to have long duration on travel not just like 1h-5h maybe like days, and want the game to be like story driven than the usual pvp or pve games out there Edited May 16, 2023 by ags_cs4 Quote Link to comment Share on other sites More sharing options...
peterisgb Posted May 16, 2023 Author Share Posted May 16, 2023 9 minutes ago, ags_cs4 said: @peterisgb i like the idea i did work on a system for a map with locations/cities (circles) and quests (scrolls), chests the game need lot of thinking than any normal browser game as i want the game to have long duration on travel not just like 1h-5h maybe like days, and want the game to be like story driven than the usual pvp or pve games out there That map.... Tbh that map looks way better and makes mine look like dog s**t lol Quote Link to comment Share on other sites More sharing options...
ags_cs4 Posted May 16, 2023 Share Posted May 16, 2023 37 minutes ago, peterisgb said: That map.... Tbh that map looks way better and makes mine look like dog s**t lol lol but yours you can travel move and stuff, mine is just showing you locations all can be changed to text based with nothing new 😄 Quote Link to comment Share on other sites More sharing options...
ags_cs4 Posted May 19, 2023 Share Posted May 19, 2023 couldnt read the code 🤣 might be better to start fresh then work on old code 😄 but the idea that allow you to walk the map and see the other player is great will be tricky to make the maps responsive without zooming and de-zooming (grafic will look bad) Quote Link to comment Share on other sites More sharing options...
peterisgb Posted May 19, 2023 Author Share Posted May 19, 2023 53 minutes ago, ags_cs4 said: couldnt read the code 🤣 might be better to start fresh then work on old code 😄 but the idea that allow you to walk the map and see the other player is great will be tricky to make the maps responsive without zooming and de-zooming (grafic will look bad) yeah, it is quite a code. Not my longest at all but pretty long 😄 My biggest mod is still in production but its upto 2300 lines and still going 😄 Quote Link to comment Share on other sites More sharing options...
peterisgb Posted May 27, 2023 Author Share Posted May 27, 2023 Ok, Well. So I don't have this on my game, this being made LONG ago and i can't be bother to optimize, So I've decided to use AI to sort it. I didn't know the bot could read pastebin!!!. This is what the bot said and now it got it to sort it haha. If you're concerned about the character limit for posting your code here, you can try breaking it down into smaller chunks and sharing them one by one. Alternatively, you can use online code-sharing platforms like GitHub Gist or Pastebin to share your code and provide the link here. That way, you can share the entire code without worrying about any character limits. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.