Deand2331 Posted July 24, 2020 Share Posted July 24, 2020 So here is my game www.mafia-streets.com feel free to come and look about. I accept all criticism constructive or bad. But it's working out alright for me. Also please feel free to give me any pointers on what could be done differently. Thanks for looking. 1 Quote Link to comment Share on other sites More sharing options...
InverTed Posted July 24, 2020 Share Posted July 24, 2020 Not bad; my only suggestion is to chill out on the text colors. I'd say pick a common color scheme and stick with it, the teal blue might hurt some eyes after a while of staring at it. Other than that, you can tell the game is in it's early stages. It's a good start :) Quote Link to comment Share on other sites More sharing options...
Zeddicus Posted July 24, 2020 Share Posted July 24, 2020 (edited) 38 minutes ago, Deand2331 said: So here is my game www.mafia-streets.com feel free to come and look about. I accept all criticism constructive or bad. But it's working out alright for me. Also please feel free to give me any pointers on what could be done differently. Thanks for looking. Hi. I'll update this post when I get the chance to play the game. I tried signing up and got the following: Your password must be 10 or less characters long Might I suggest removing that? I completely understand a minimum size for a password but a maximum character count of 10 is very small. LINKS Redirect to external pages that don't work. https://mafia-streets.com/l.php?u=https://www.https://mafia-streets.com/tasklist.php https://mafia-streets.com/l.php?u=https://www.https://mafia-streets.com/lucky_dip.php https://mafia-streets.com/l.php?u=https://www.https://mafia-streets.com/downtown.php https://mafia-streets.com/l.php?u=https://www.https://mafia-streets.com/city.php https://mafia-streets.com/l.php?u=https://www.https://mafia-streets.com/guide.php https://mafia-streets.com/l.php?u=https://www.https://mafia-streets.com/forum/6.php Edited July 24, 2020 by Zeddicus Updated due to bug found. Quote Link to comment Share on other sites More sharing options...
InverTed Posted July 24, 2020 Share Posted July 24, 2020 So after some browsing around and playing, i decided to peak at your donation page. I'm not typically one to judge, but I think some of your prices should probably see adjustment. $20 for a 30 day membership is a bit steep, and honestly i do not think you'll see a ton of people investing in it. But this is your game, I'm just offering up a little thought on that, there is not enough in a package to benefit the player who's spending money on your game. I'm not saying ADD MORE to the package, just rethink the pricing. Best of luck :) Quote Link to comment Share on other sites More sharing options...
Deand2331 Posted July 24, 2020 Author Share Posted July 24, 2020 36 minutes ago, InverTed said: So after some browsing around and playing, i decided to peak at your donation page. I'm not typically one to judge, but I think some of your prices should probably see adjustment. $20 for a 30 day membership is a bit steep, and honestly i do not think you'll see a ton of people investing in it. But this is your game, I'm just offering up a little thought on that, there is not enough in a package to benefit the player who's spending money on your game. I'm not saying ADD MORE to the package, just rethink the pricing. Best of luck 🙂 $30 ?? Its $3 lol but thanks for the feed back Just now, Deand2331 said: $30 ?? Its $3 lol but thanks for the feed back 10 Coins = $1 USD its 30 coins for the members ship Quote Link to comment Share on other sites More sharing options...
InverTed Posted July 24, 2020 Share Posted July 24, 2020 I'm not talking about the actual just RM packs, my reference wasn't on point, I meant to aim that at the Starter pack. That was my bad. Quote Link to comment Share on other sites More sharing options...
ags_cs4 Posted July 24, 2020 Share Posted July 24, 2020 i gota say you need lot of work on your theme, and colors, they all must work together, as for the black Background i recommend u use a brighter dark it hurt the eye with the blue/yellow color u are using, see twitter dark mode and you will know what i mean 1 Quote Link to comment Share on other sites More sharing options...
sniko Posted July 24, 2020 Share Posted July 24, 2020 (edited) Your `l.php` script is also prone to XSS... An example: https://mafia-streets.com/l.php?u=l.php%3Cscript%3Edocument.location.href%3D%27https%3A%2F%2Fharrydenley.com%2F%27%3B%3C%2Fscript%3E - of course this is just a PoC, but could be harnessed for CSRF or something else. You do not validate or sanitize if the path is urlencoded Edited July 24, 2020 by sniko 1 Quote Link to comment Share on other sites More sharing options...
Deand2331 Posted July 25, 2020 Author Share Posted July 25, 2020 15 hours ago, InverTed said: I'm not talking about the actual just RM packs, my reference wasn't on point, I meant to aim that at the Starter pack. That was my bad. ok great thanks for the input i will take it on board but to be fair with you thats my best seller lol alot of donations for that package 13 hours ago, sniko said: Your `l.php` script is also prone to XSS... An example: https://mafia-streets.com/l.php?u=l.php%3Cscript%3Edocument.location.href%3D%27https%3A%2F%2Fharrydenley.com%2F%27%3B%3C%2Fscript%3E - of course this is just a PoC, but could be harnessed for CSRF or something else. You do not validate or sanitize if the path is urlencoded brilliant thank you for that i will get right to that Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.