bladewolf2010 Posted August 24, 2010 Posted August 24, 2010 I know this isn't really a mod but it's a little thing that helps players see what the staff do (like what there duties are) having that in the stafflist.php will save them the trouble from going to each staff member's profile just to see the duties You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. Quote
rulerofzu Posted August 24, 2010 Posted August 24, 2010 Good effort there blade at least your continuing to try and learn. Id suggest not doing this SELECT * FROM users especially from a table like users which is quite large. No need. SELECT userid,username,duties FROM users will suffice as that's all the info that you need. Also duties is a new field which you didnt mention :P Quote
bladewolf2010 Posted August 24, 2010 Author Posted August 24, 2010 Okay thanks for the advise :) Quote
Jordan Palmer Posted August 24, 2010 Posted August 24, 2010 Here is a smaller patch for this Secured Cleaner Valid CSS (Personal view *more*) General Optimization (queries) You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. Fully working and tested Quote
bladewolf2010 Posted August 24, 2010 Author Posted August 24, 2010 At least i'm trying now :pinch: Quote
Paul Evans Posted August 24, 2010 Posted August 24, 2010 I really dislike people opening and closing the php tags lol Quote
The Spirit Posted August 24, 2010 Posted August 24, 2010 I really dislike people opening and closing the php tags lol Why? Just want to know :) Quote
Paul Evans Posted August 24, 2010 Posted August 24, 2010 A friend of mine a while back said it was a security risk (never researched it personally (i may have to)) and it looks horrid lol Quote
bladewolf2010 Posted August 24, 2010 Author Posted August 24, 2010 I don't do that mainly because i don't understand the point when you can just do it in tags right? Quote
The Spirit Posted August 25, 2010 Posted August 25, 2010 A friend of mine a while back said it was a security risk (never researched it personally (i may have to)) and it looks horrid lol Ok thanks :) Quote
Djkanna Posted August 25, 2010 Posted August 25, 2010 A friend of mine a while back said it was a security risk (never researched it personally (i may have to)) and it looks horrid lol No security risks, as far as in writing your html outside of PHP. However it's much cleaner to do so unfortunately source code viewers like [.php][/.php] haven't quite picked up on so it looks somewhat unpleasing on the forum. The way Jordan did I wouldn't say it's wrong but he's still using echo to write html/text to the page, where following the rest of the style of the script you'd do something like the following for example. You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. Or a more realistic example of what you'd use in MCCodes; You're unable to view this code. Viewing code within this forum requires registration, you can register here for free. It's a rather effective method of doing it and also in some ways speeds up development time. Quote
Uridium Posted August 25, 2010 Posted August 25, 2010 I really dislike people opening and closing the php tags lol opening and closing tags is sometimes a good thing especially when using net beans as you can insert html into a html section but not from an echo ;) if your using netbeans its a god Quote
Jordan Palmer Posted August 25, 2010 Posted August 25, 2010 @DJK, Yeah, Sorry I ended up coming off the laptop so had to rush to finish @Paul; I never really do, but I was bored lol Quote
Wazam Posted August 25, 2010 Posted August 25, 2010 Nice little work here bud. It's kind of crapmed, kind of simple kind of coding. Might want to make it more clear to people. Good effort though. :) Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.