yet another secure error

[Legaci]

$q=$dbh->query("SELECT count(*) FROM userstats us LEFT JOIN users u ON us.userid=u.userid WHERE us.=? > ? AND us.userid != ? AND u.user_level != 0", $mykey, $stat, $userid) ;
return $db->fetch_single($q)+1;

 

there is an error with this

this is the message

Fatal error: Call to a member function query() on a non-object in /home/bravelan/public_html/global_func.php on line 285

[Dayo]

You have a problem with the function query look at the variable/class calling it

rather then just post the awnser ill help you fix it yourself ;)

[Legaci]

where is the variable

[Dominion]

When posting errors just the line rarely helps. Next time post a little both ways (e.g. 10 lines either side) or the whole function it's in.

In this case take a look at another function in the same file using a query in it (e.g. itemtype_dropdown()). Take note of the first few lines.

[Legaci]

function get_rank($stat, $mykey)

{

global $db;

global $ir,$userid,$c;

$q=$dbh->query("SELECT count(*) FROM userstats us LEFT JOIN users u ON us.userid=u.userid WHERE us.=? > ? AND us.userid != ? AND u.user_level != 0", $mykey, $stat, $userid) ;

return $db->fetch_single($q)+1;

}

 

this is the function

[KyleMassacre]

Since that class isn't a standard mc code class a lot of people won't know what your talking about but you have in the us.=? so remove the "="

[Guest]

Should be $db->query not $dbh->query

[KyleMassacre]

Should be $db->query not $dbh->query

Its right Ian, he is using another class. But I think I remember him saying that he instantiated the class towards the bottom of his page and I didn't pay attention then but Legaci, call your new class the dbWrapper towards the top of your global func file

[Guest]

Its right Ian, he is using another class. But I think I remember him saying that he instantiated the class towards the bottom of his page and I didn't pay attention then but Legaci, call your new class the dbWrapper towards the top of your global func file

Then surely he needs global $dbh? And why would you use $dbh for the query then $db for the result? :confused:

[KyleMassacre]

the class is still a work in progress ;) Atleast his db execution queries are binded properly using a mysqli class for now so he just needs to incorporate a fetch function for his queries

[Guest]

So confused, maybe that's where it is going wrong, possibly losing it after doing the query to when he wants the results? Wild guess, i'm totally lost with this one sorry

[KyleMassacre]

well I had him keep the original class for now because of gaps like this but here is the class he's using https://github.com/vjeux/MysqliWrapper/blob/master/src/mysqli-wrapper.php

[Legaci]

i removed to = but still the same problem is arising

[Dominion]

I assume $dbh is set somewhere?

It needs to be used in the same way as $db meaning something is missing (global...).

[Legaci]

$dbh is in global is just an alteration to $db

[Legaci]

turns out is wasnt a Db query i was looking at it and new that wasnt correct so here is my resolved problem

 

function get_rank($stat, $mykey)
{
global $ir,$userid,$c;
$q=mysql_query("SELECT count(*) FROM userstats us LEFT JOIN users u ON us.userid=u.userid WHERE us.$mykey > $stat AND us.userid != $userid AND u.user_level != 0", $c) ;
return mysql_result($q,0,0)+1;
}

 

Thanks for the help