Steal money & crystals

[lucky3809]

This mod was requested by $Chinion$...

What this does is allow you to steal money and crystals from other players, it takes 10 energy to perform one steal...

This can be modify to steal from banks just change the money part to bankmoney... right now I have it taking from money out of the bank...Create a new file call it steal.php

 

You're unable to view this code.

Viewing code within this forum requires registration, you can register here for free.

 

Screenshots...

 

NOTE: If the code did not show up correctly let me know and i will take off the bbcode tags.. im using firefox and see br tags everywhere o.O

Edited April 24, 2011 by lucky3809
recoded.

[lucky3809]

This is the style that goes up above the page...

<style type="text/css">

.steals_msg {

color: #009900;

margin: 0;

padding: 2px 0px 2px 12px;

}

.steals {

border: 1px #009900 solid;

background-color: #eee;

width: 55%;

margin: 0 auto;

padding: 8px 15px 3px 15px;

}

.steal_msg {

color: #000;

margin: 0;

padding: 2px 0px 2px 12px;

}

.steal {

border: 1px #000 solid;

background-color: #eee;

width: 55%;

margin: 0 auto;

padding: 8px 15px 3px 15px;

}

.stealhj {

border: 1px maroon solid;

background-color: #eee;

width: 55%;

margin: 0 auto;

padding: 8px 15px 3px 15px;

}

.stealhj_msg {

color: maroon;

margin: 0;

padding: 2px 0px 2px 12px;

}

 

</style>

 

Forgot lol....

For those that dont know how to create the link to the steal page you place this on the viewuser.php

<a href="steal.php?ID='.$r['userid'].'">Steal</a>

Edited April 20, 2011 by lucky3809

[rulerofzu]

One thing that immediately popped up was

$_GET['action'] = (int)

however on its usage

$_GET['action'] ='money'; <----- thats not a number

Found it curious the usage of abs(intval($_SESSION['userid'])) and your not checking the crystals or money

Its much better assigning a var to the checking in my opinion.

$id=(isset($_GET['ID']) && ctype_digit($_GET['ID'])) ? $_GET['ID'] : '';

Then use the var in your queries.

Having already checked the ID so is there any need for abs(intval($_GET['ID']))

Nothing really bad with what you have done so well done :D

Edited April 20, 2011 by rulerofzu

[a_bertrand]

I really wonder why all of you use the abs(intval($var)) idea... Is a negative number a problem for an id? I doubt. Second it would be much much shorter and faster to write simply $var+=0 and your $var is in any case then a number and you will not risk any SQL injections from it anymore.

[Joshua]

I know on some modifications the entry of -99999999999999999999 or +9999999999999- Will cause an error in the script crediting the users with entirely to much money.

this is why most use abs(int) or ctype_digit

[lucky3809]

thanks for the input...$var+=0 I didnt know about that, will look it up and practice using that. I haven't covered all the basics, iam no expert lol. I just know somethings that do work for me.

I use abs(intval for many reason one in which Joshua said and another when someone enters for instant http://www.game.com/steal.php?ID='1' in the url, I dont want it to show a query error like it would show if I had not used it in the link directing from the users profile. I dont want users to enter in an invalid statement..

I know I could prevent the error message from showing by adding @$db->query...

[a_bertrand]

if you use the +0 trick it would not show any error as in the worse case it would be 0 after conversion.

[rulerofzu]

Much better to have PHP error messages on whilst your coding and then if you feel like it turn them off before you go live.

In Mc2 in the db class you can alter the message shown in game for db errors so the user only sees a oops sorry please report it in message.

There is a modification on here for it somewhere.

The session ID shouldnt need to be checked like that as it should have been set correctly upon login

[shinobi]

Error

Hey , i installed this and i had a few errors .. i fixed some and the page finally showed up:

this it what it say all the time :

Stealing Error

Player does not exist.

 

any ideas how to fix it

[rulerofzu]

Generally scripts such as this will not work if you put in a browser steal.php it has to have the players ID.

[lucky3809]

Sorry the end of the script should be...

I forgot the $id = part....

 

$id=(isset($_GET['ID']) && ctype_digit($_GET['ID'])) ? $_GET['ID'] : '';

$user=$db->query("SELECT username FROM users WHERE userid='$id'")or die(mysql_error());

$r=$db->fetch_row($user);

echo '

Each steal cost 10 energy, you have '.$ir['energy'].' energy.<br />

You may steal the following from '.$r['username'].'...<br /><br />

<table><tr><td >

<a href="steal.php?ID='.$id.'&action=money">Money</a> | 

<a href="steal.php?ID='.$id.'&action=crystals ">Crystals

</a></td></table>';

$h->endpage();

 

I updated the main post

also for those using the script some of the mres has a space due to the forum you need to back space them.

also dont forget you cant just link the page to steal.php it has to be steal.php?ID='.$r['userid'].' as typed in second posting lol....

Edited April 24, 2011 by lucky3809

[rulerofzu]

There is really no need for

$_GET['action'] == mysql_real_escape_string($_GET['action']);

[lucky3809]

fair enough i deleted it.

[Djkanna]

There is really no need for

$_GET['action'] == mysql_real_escape_string($_GET['action']);

Should only have one equal sign there :P

Good job Lucky.

[tezzmosis]

anyways this could be updated?

[rulerofzu]

Go ahead and update it then tezzmosis.

[lucky3809]

your more then welcome to update it if you want to tezzmosis, but i wont be updating it, there is no need of updating it the main thing the requester wanted was for a player to be able to steal cash and crystals from other players, and that's exactly what it does.

[SilvaTungDevil]

this kind of mod confuses me a little. You want donators to buy cystals yet you then put them at risk of having their crystals stolen. I know if i just spent whatever amount on crystals from your upgrade store that i would be quite mad if they was stolen from me by another player who hasnt paid to play.

Just my thought though :D

[lucky3809]

I made this mod for $Chinion$ he requested it..

http://makewebgames.io/showthread.php/39050-Would-this-cost

If you do not want crystals stolen you can easily remove that part, and only have cash...

$chinion$ asked for a mod where players can steal money and crystals,because on his game crystals are easy to get... I preferably wouldn't want crystals being stolen, but i did not make this mod for myself, i made it for $chinion$ on request... so ask him why he wants crystals stolen lol...

Edited June 7, 2011 by lucky3809