Cmarket

[Paddy Green]

Hey Der,

Well I didn't mention this in my forum post, but for about a week, I looked through Mccodes files and stuff. See how stuff work. I've looked at a couple of threads, saying what could be done and so... Shongoon. Anyway. Here's a Cmarket.php I found through MWG, and I just did what I can. Now in-case any of you wonder. I don't waste no time on the laptop going on games, since I get other stuff to-do, I can't waste any time learning. So your thoughts on my first ever modification? (Hasn't been tested as I don't own Mccodes V2): Please posts up errors, and hopefully there isn't any bugs. ^^

 

You're unable to view this code.

Viewing code within this forum requires registration, you can register here for free.

 

Now just to let you no - $_GET['action'] = (isset($_GET['action']) && is_string($_GET['action'])) ? strtolower(trim($_GET['action'])) : false;; - I found it on a secure script. I looked up on what Isset && Is_srting does, and how it does "secure" it, but I'll understand soon. If you could take 5-10 minutes of your time explaining on how it does and that, I would be very grateful. Until next time, I'm Paddy Green, reporting from My laptop.

[Joshua]

WHERE `cmID = ".ID." AND `cmADDER` = $userid");

just skimmed through it real fast and noticed you're missing a ` after cmID

That'll error.

Doesnt look to horrid, nice spacing at least ;d

[Paddy Green]

Sorted.

Also fixed that ($) needed. "Doesn't look to horrible" Why thank you. :P

[Djkanna]

Meh just a pet peeve of mine but try camelCase for your variable names :)

$Blahdeblah looks urgh

$blahDeBlah looks nicer imo

[sniko]

. Some hosts (or browsers, forgot which) dont allow the short opening of tags

. Why echo every line (22 - 24) ?

Other than that, good.

[Paddy Green]

@ Dj:

Hha.. Thanks mate. Also, did you do something with your hair? :P

@ Sniko:

Hm.. Thanks for information. Just my personal preference buddy.

[Djkanna]

@ Dj:

Hha.. Thanks mate. Also, did you do something with your hair? :P

Ha, no problem.

[Swift-Fusion || Fusion]

Sniko: Some serves disable the use of the php short tag