Paul Evans

zu try running the crons for hosp/jail issues

that is very unusual as the crimes system is exactly the same as the crime system on v2.0.3

fair point by everyone, Dominion i do agree it was released a bit prematurely but not many people did actually goto the sample and test for bugs even when the password for staff panel was realised they simply did silly things like change the staff password and not change it back or edit the passwords on the demo/admin accounts (i think they fixed them editing this).

Fixing the issues is the soul responsibility of the creator but if they do not know of the issues then it's impossible for them to do so, i always say the coder of a script is too far involved to find even simple bugs which is why they rather sit back and look over it for a period or they release a sample. I knew the staff password it wasn't that difficult to figure out 'admin' lol although it may have not been active for awhile due to issues where members nicely edited the staff password and bull like that. Personally i think it's a improvement on v1/v2 atleast but i would go no where near saying it's as buggy (not seen a hack yet) there maybe afew bugs but if people reported them (i know some have) then it would be easier for them to fix 'em. Your helping yourself and any other customers by reporting the issues and im sure DB/CB appreciate it a hell of a lot that customers report bugs. Although i remember not many years back when v2 was it's base shell and Mccodes wasn't even around to fix the bugs so come on they are here they are fixing any issues you have and you still bloody complain. can't please anyone...

did they not do a fresh install for members to look over before they released it forsale?

works on crons try setting up the crons... also to answer #16 try going to http://redux.mccodes.com/staff.php?page=users and tell me what's at the bottom of the list... lol #18 #20 - not really a issue. #22   ah have you hacked it?

or you could add a ! infront of the in_array and it would fix it lol easy mistake to make.

Mike on the redux sample website them issues seem to be fixed? so im guessing they have actually listened to you and fixed them.

Nice mod mate

LOL aye i noticed alot of people partly secure scripts and believe it's fine... oh well

if it was a Free mod as i believe it was my edit of that file can be used by redux: <?php /* Engine: MC V2.5 (Redux) File: ogcrime.php Author: MakeWebGames.com */ if ( !defined($_CONFIG['define_code']) ) { echo 'This file cannot be accessed directly.'; exit; } if ( $ir['user_level'] != 2 ) { echo 'You cannot access this area.> <a href="'.gen_url('main',true,true).'">Go Back</a>'; die($h->endpage()); } switch ( $_GET['action'] ) { case 'index': index(); break; case 'newoc': new_orgcrime_form(); break; case 'newocsub': new_orgcrime_submit(); break; case 'editoc': edit_orgcrime_form(); break; case 'editocsub': edit_orgcrime_submit(); break; case 'deloc': del_orgcrime_form(); break; case 'delocsub': del_orgcrime_submit(); break; case 'stopoc': stop_orgcrime_form(); break; case 'stopocsub': stop_orgcrime_submit(); break; default: index(); break; } function index() { global $ir; if ( $ir['user_level'] == 2 ) { echo ' <table class="table" cellpadding="1" cellspacing="1" width="70%" style="text-align: center;"> <tr> <th>Organised Gang Crimes</th> </tr> <tr> <td>> <a href="'.gen_url('ogcrimes',true,true).'&action=newoc">New Organised Crime</a></td> </tr> <tr> <td>> <a href="'.gen_url('ogcrimes',true,true).'&action=editoc">Edit Organised Crime</a></td> </tr> <tr> <td>> <a href="'.gen_url('ogcrimes',true,true).'&action=deloc">Delete Organised Crime</a></td> </tr> <tr> <td>> <a href="'.gen_url('ogcrimes',true,true).'&action=stopoc">Stop Organised Crime</a></td> </tr> <tr> <th>> <a href="'.gen_url('main',true,true).'">Goto Main</a></th> </tr> </table> '; } } function new_orgcrime_form() { global $ir, $db; echo " Adding a new organized crime. <form action='".gen_url('ogcrimes',true,true)."&action=newocsub' method='post'> Org Crime Name: <input type='text' name='name' /><br /> Min. Members Needed: <input type='text' name='members' /><br /> Start Text: <textarea rows=4 cols=40 name='stext' /></textarea><br /> Success Text: <textarea rows=4 cols=40 name='sctext' /></textarea><br /> Failure Text : <textarea rows=4 cols=40 name='ftext' /></textarea><br /> Min Success Money: <input type='text' name='minmoney' /><br /> Max Success Money: <input type='text' name='maxmoney' /><br /> <input type='submit' value='Create Crime' /> </form> "; } function new_orgcrime_submit() { global $ir,$userid, $db; $name = ( isset($_POST['name'])&&preg_match("/^[a-z0-9_]+([\\s]{1}[a-z0-9_]|[a-z0-9_])+$/i", $_POST['name']) )?strip_tags($db->escape($_POST['name'])):''; $members = ( isset($_POST['members'])&&is_numeric($_POST['members']) )?abs(intval($_POST['members'])):1; $stext = ( isset($_POST['stext']) )?strip_tags($db->escape($_POST['stext'])):''; $sctext = ( isset($_POST['sctext']) )?strip_tags($db->escape($_POST['sctext'])):''; $ftext = ( isset($_POST['ftext']) )?strip_tags($db->escape($_POST['ftext'])):''; $minmoney = ( isset($_POST['minmoney'])&&is_numeric($_POST['minmoney']) )?abs(intval($_POST['minmoney'])):''; $maxmoney = ( isset($_POST['maxmoney'])&&is_numeric($_POST['maxmoney']) )?abs(intval($_POST['maxmoney'])):''; if ( empty($name) OR empty($members) OR empty($minmoney) OR empty($maxmoney) OR empty($stext) OR empty($sctext) OR empty($ftext) ) { echo 'One or more of the inputs seems to of the wrong format, please go back and try again.<br />> <a href="'.gen_url('ogcrimes',true,true).'&action=newoc">Go back</a>'; die($h->endpage()); } $db->query("INSERT INTO `orgcrimes` (ocNAME, ocUSERS, ocSTARTTEXT, ocSUCCTEXT, ocFAILTEXT, ocMINMONEY, ocMAXMONEY) VALUES( '$name', '$members', '$stext', '$sctext', '$ftext', '$minmoney', '$maxmoney')"); echo "Organized Crime created!"; stafflog_add("Created orginized crime {$name}"); } function edit_orgcrime_form() { global $ir, $db; echo " Editing Org Crime. <form action='".gen_url('ogcrimes',true,true)."&action=editocsub' method='post'> Current Crime: ".orgcrime_dropdown($c,'ocID')."<br /> New Org Crime Name: <input type='text' name='name' /><br /> New Min. Members Needed: <input type='text' name='members' /><br /> New Start Text: <textarea rows=4 cols=40 name='stext' /></textarea><br /> New Success Text: <textarea rows=4 cols=40 name='sctext' /></textarea><br /> New Failure Text : <textarea rows=4 cols=40 name='ftext' /></textarea><br /> New Min Success Money: <input type='text' name='minmoney' /><br /> New Max Success Money: <input type='text' name='maxmoney' /><br /> <input type='submit' value='Edit Orginized Crime' /> </form> "; } function edit_orgcrime_submit() { global $ir,$userid, $db,$h; $name = ( isset($_POST['name'])&&preg_match("/^[a-z0-9_]+([\\s]{1}[a-z0-9_]|[a-z0-9_])+$/i", $_POST['name']) )?strip_tags($db->escape($_POST['name'])):''; $members = ( isset($_POST['members'])&&is_numeric($_POST['members']) )?abs(intval($_POST['members'])):1; $stext = ( isset($_POST['stext']) )?strip_tags($db->escape($_POST['stext'])):''; $sctext = ( isset($_POST['sctext']) )?strip_tags($db->escape($_POST['sctext'])):''; $ftext = ( isset($_POST['ftext']) )?strip_tags($db->escape($_POST['ftext'])):''; $minmoney = ( isset($_POST['minmoney'])&&is_numeric($_POST['minmoney']) )?abs(intval($_POST['minmoney'])):''; $maxmoney = ( isset($_POST['maxmoney'])&&is_numeric($_POST['maxmoney']) )?abs(intval($_POST['maxmoney'])):''; $ocID = ( isset($_POST['ocID'])&&is_numeric($_POST['ocID']) )?abs(intval($_POST['ocID'])):''; if ( empty($ocID) OR empty($name) OR empty($members) OR empty($minmoney) OR empty($maxmoney) OR empty($stext) OR empty($sctext) OR empty($ftext) ) { echo 'One or more of the inputs seems to of the wrong format, please go back and try again.<br />> <a href="'.gen_url('ogcrimes',true,true).'&action=editoc">Go back</a>'; die($h->endpage()); } $c_ogc = $db->query('SELECT `ocID` FROM `orgcrimes` WHERE `ocID` = '.$ocID); if ( $db->num_rows($c_ogc) == 0 ) { echo 'Organised Gang Crime doesn\'t exist.<br />> <a href="'.gen_url('ogcrimes',true,true).'&action=editoc">Go back</a>'; die($h->endpage()); } $db->query("UPDATE `orgcrimes` SET `ocNAME`='$name', `ocUSERS`='$members', `ocSTARTTEXT`='$stext', `ocSUCCTEXT`='$sctext', `ocFAILTEXT`='$ftext', `ocMINMONEY`='$minmoney', `ocMAXMONEY`='$maxmoney' WHERE `ocID`={$ocID}"); echo "Organized Crime edited!"; stafflog_add("Edited Orginized crime {$name}"); } function del_orgcrime_form() { global $ir, $db; echo " Deleting Org Crime. <form action='".gen_url('ogcrimes',true,true)."&action= delocsub' method='post'> Org Crime: ".orgcrime_dropdown($c,'ocID')." <input type='submit' value='Delete Orginized Crime' /> </form> "; } function del_orgcrime_submit() { global $ir,$userid, $db; $ocID = ( isset($_POST['ocID'])&&is_numeric($_POST['ocID']) )?abs(intval($_POST['ocID'])):''; $c_ogc = $db->query('SELECT `ocID` FROM `orgcrimes` WHERE `ocID` = '.$ocID); if ( $db->num_rows($c_ogc) == 0 ) { echo 'Organised Gang Crime doesn\'t exist.<br />> <a href="'.gen_url('ogcrimes',true,true).'&action=editoc">Go back</a>'; die($h->endpage()); } $db->query("DELETE FROM `orgcrimes` WHERE `ocID`={$ocID}"); echo "Organized Crime Deleted!</div>"; stafflog_add("Deleted Orginized Crime ID: {$ocID}"); } function stop_orgcrime_form() { global $ir, $db; echo " Stopping Org Crime This allows you to stop any organized crimes associated with a gang <form action='".gen_url('ogcrimes',true,true)."&action= stopocsub' method='post'> Gang: ".gang_dropdown($c,'gangID')." <input type='submit' value='Stop Organized Crime' /> </form> "; } function stop_orgcrime_submit() { global $ir,$userid, $db; $gangID = ( isset($_POST['gangID'])&&is_numeric($_POST['gangID']) )?abs(intval($_POST['gangID'])):''; $c_gng = $db->query('SELECT `gangID` FROM `gangs` WHERE `gangID` = '.$gangID); if ( $db->num_rows($c_gng) == 0 ) { echo 'Gang doesn\'t exist.<br />> <a href="'.gen_url('ogcrimes',true,true).'&action=stopoc">Go back</a>'; die($h->endpage()); } $db->query("UPDATE `gangs` SET `gangCRIME`='0', `gangCHOURS`='0' WHERE `gangID`={$gangID}"); echo "Organized Crime Stopped!"; stafflog_add("Stopped Organized Crime For Gang ID {$gangID}"); } ?> Also it's secure... lol unlike the version you posted (shameful you forgot that huh (LOL)) Opps forgot the edits global_func.php: function orgcrime_dropdown ($connection,$ddname="ogID",$selected=-1) { global $db; $ret="<select name='$ddname' type='dropdown'>"; $q = $db->query("SELECT `ocNAME`,`ocID` FROM `orgcrimes` ORDER BY `ocNAME` ASC"); if($selected == -1) { $first = 0; } else { $first = 1; } while ( $r = $db->fetch_row($q) ) { $ret.="\n<option value='{$r['ocID']}'"; if ( $selected == $r['crimeID'] || $first == 0 ) { $ret.=" selected='selected'"; $first=1; } $ret.=">{$r['ocNAME']}</option>"; } $ret.="\n</select>"; return $ret; } function gang_dropdown($connection, $ddname = "gangID", $selected = -1) { global $db; $ret = "<select name='$ddname' type='dropdown'>"; $q = $db->query( "SELECT `gangID`, `gangNAME` FROM `gangs` ORDER BY `gangNAME` ASC"); if ($selected == -1) { $first = 0; } else { $first = 1; } while ($r = $db->fetch_row($q)) { $ret .= "\n<option value='{$r['gangID']}'"; if ($selected == $r['gangID'] || $first == 0) { $ret .= " selected='selected'"; $first = 1; } $ret .= ">{$r['gangNAME']}</option>"; } $db->free_result($q); $ret .= "\n</select>"; return $ret; } and smenu.php: <br /> <span style='font-weight: none;'><a href='".gen_url('ogcrimes',true,true)."'>Organised Crimes</a></span> Add them in sufficient places. Also edit staff.php and add: 'ogcrimes' => 'Staff/ogcrimes.php', into the file array.

Yeah to be honest though i've never even used that mod lmao although i think the mod you posted may have been a free mod back in CE days. Although for Redux you'd need a little more.

function del_orgcrime_submit() { global $ir,$userid, $db; $db->query("DELETE FROM orgcrimes WHERE ocID={$ocID}"); Tell me what i just noticed within 30 seconds of looking over this file... Are you the original author Ruler?

believing and actually having is a little different, you may wanna check up on that.

Wow talk about illegal use of images, see you in court.

i played this game, noelle originally owned it i believe (have not spoken to her in awhile) floydian was a coder on there (i was once one of the richest on the game and was first mmorpg i played), it's based on mc v1 and was extremely edited to suit the games theme (pirates). The owner is a poker player atm i believe. You could easily replicate the game with another engine the only brilliant aspect was it's theme due to POC coming out near to the time of it opening, POC 4 is out now so im not surprised people wanna play it again or recreate it. Although it would be quite simple to make a better version of that game using another engine as MC v1 does have many issues with it's code. Good luck.

Do YOU own the rights to sell it?

naw i posted my build link function though, which is quite similar, simply a shortened version of Alan's script which he did when doing his engine. Gen URL is this function gen_url( $url, $main = false, $admin = false ) { if ( !empty($url) ) { if ($main == false) { return 'invalid link'; } elseif ($main === 'hidden') { return '<input type=hidden name=page value='.$url.' />'; } elseif ($main === 'get' && !empty($admin) ) { return '<input type=hidden name='.$admin.' value='.$url.' />'; } elseif ($main == true) { return sprintf(''.(($admin==false)?'index':'staff').'.php?page=%1$s', $url); } } else { return (($admin==false)?'index':'staff').'.php?page=index'; } return false; }

Daniel your mistaken, i have noticed in some files they left in $h->endpage(); but i think they accounted for that with a code somewhere maybe header i've only had a small look over the engine myself to post this thread so... honestly i wouldn't know. Ruler i think maybe optimized was the wrong word they have although made it easier to add in mods and addons to the script than previous versions and it's a lot tidier (on FTP) and organised than any MC i've seen. Although i'm sure there is a few draw backs to organising the files, the Gen_URL function is quite impressive they accounted for a few things in that but i think they could of worked on it a little longer to shorten it maybe. Anyways hope this helps someone. and remember this is a teaser script for V3

Starting from the top of any file from v2.0.3, Find: include_once "globals.php"; Replace with: if ( !defined($_CONFIG['define_code']) ) { echo 'This file cannot be accessed directly.'; exit; } Then find any links for example like link.php and edit them like the following examples Example 1 echo '<a href="'.gen_url('link',true).'">link</a>'; instead of echo '<a href="link.php">link</a>'; Example 2 echo "<a href='".gen_url('link',true)."'>link</a> instead of echo "<a href='link.php'>link</a>"; Example 3 $var = gen_url('link',true); instead of $var = 'link.php'; This is only for index.php added files you would need to add a extra parameter if you were editing a staff file. Example of a staff file link would be gen_url('link',true,true); in the same methods as shown above. Finally remove the following code from all files (mods/staff) when converting to v2.5. $h->endpage();   Also don't forget to add the files in the specified folders (for example staff files into Staff DIR or Mods into Mods DIR). When your adding a file to a index you need to edit rather the index.php or staff.php which are located in the Public_html DIR. Example (edit the $file_array array and add in a new entry like below): 'link' => 'Mods/link.php',   NOTE: If any sections of this are incorrect i will edit them ASAP but i only did this as a favour so please post below if any issues occur while converting 2.0.3 to 2.5

docrime.php Yeah i just noticed the crimes issue myself, lol didn't even notice it on the sample they released so im not surprised they missed it since we (us lot) did the bug testing aswell docrime.php: <?php /* Engine: MC V2.5 (Redux) File: docrime.php Author: mccodes.com */ if ( !defined($_CONFIG['define_code']) ) { echo 'This file cannot be accessed directly.'; exit; } if ( $ir['jail'] or $ir['hospital'] ) { echo 'This page cannot be accessed while in jail or hospital.'; die($h->endpage()); } $_GET['c'] = ( isset($_GET['c'])&&is_numeric($_GET['c']) )?abs(intval($_GET['c'])):''; if ( empty($_GET['c']) ) { echo "Invalid crime"; } else { $q = $db->query('SELECT * FROM `crimes` WHERE `crimeID` = '.$_GET['c']); if ( $db->num_rows($q) == 0 ) { echo 'Invalid Crime'; die($h->endpage()); } $r = $db->fetch_row($q); if($ir['brave'] < $r['crimeBRAVE']) { echo "You do not have enough Brave to perform this crime."; } else { $ec="\$sucrate=".str_replace(array("LEVEL","CRIMEXP","EXP","WILL","IQ"), array($ir['level'], $ir['crimexp'], $ir['exp'], $ir['will'], $ir['IQ']),$r['crimePERCFORM']).";"; eval($ec); echo $r['crimeITEXT']; $ir['brave'] -= $r['crimeBRAVE']; $db->query("UPDATE users SET brave={$ir['brave']} WHERE userid=$userid",$c); if ( rand(1,100) <= $sucrate ) { echo str_replace("{main}",$r['crimeSUCCESSMUNY'],$r['crimeSTEXT']); $ir['main']+=$r['crimeSUCCESSMUNY']; $ir['second']+=$r['crimeSUCCESSCRYS']; $ir['exp']+=(int) ($r['crimeSUCCESSMUNY']/8); $db->query("UPDATE `users` SET `main` = {$ir['main']}, `second` = {$ir['second']}, `exp` = {$ir['exp']},`crimexp` = `crimexp` + {$r['crimeXP']} WHERE `userid` = $userid",$c); if($r['crimeSUCCESSITEM']) { item_add($userid, $r['crimeSUCCESSITEM'], 1); } } else { if ( rand(1, 2) == 1 ) { echo $r['crimeFTEXT']; } else { echo $r['crimeJTEXT']; $db->query("UPDATE `users` SET `jail` = '$r[crimeJAILTIME]', `jail_reason` = '$r[crimeJREASON]' WHERE `userid` = '$userid'"); } } echo "<br /><a href='".gen_url('docrime',true)."&c={$_GET['c']}'>Try Again</a><br /><a href='".gen_url('criminal',true)."'>Crimes</a>"; } } ?>

I'm sorry do you log every users ip when they log in?

Yeah that actually wouldn't be so difficult to code up im sure someone will within time. Did anyone else notice the issue with superglobal GET in redux it works very unusually lol

Although then Mike wouldn't most of the logs be a waste of time if you did that? Which then leaves staff mods lazing around doing nothing.

yeah it should be macro not marco... wow typo error ^i even looked at that for like 5 minutes thinking... what's wrong then lol