Jump to content
MakeWebGames

Viewuser problem


Criminal
 Share

Recommended Posts

Hello i hated the normal v2 viewuser.php so i coded my own when i go on my user name it bes proper like what i have coded

proper screenshot:

http://img137.imageshack.us/my.php?imag ... robqz8.gif

and on this screenshot its not proper its all over the place can you tell me what the problem could be and how to fix it please

not proper screenshot

http://img231.imageshack.us/my.php?imag ... ob1ua8.gif

Link to comment
Share on other sites

Guest Anonymous

Re: Viewuser problem

I did suggest judicious use of the border=1 attribute in his tables - looks to me like a missing or malformed closing tag, although the same effect could be achieved by a rogue ' in an element's attribute.

A syntax highlighting editor here may help - EditPlus was my favorite under the dreaded Winblows OS, or point the source the the W3C validation routines .. (on second thoughts, better not, it will just confuse the socks off ya)

Link to comment
Share on other sites

Re: Viewuser problem

here is the viewuser.php

 

<?php
include "globals.php";
$_GET['u'] = abs((int) $_GET['u']);
if(!$_GET['u'])
{
print "Invalid use of file";
}
else
{
$q=$db->query("SELECT u.*,us.*,c.*,h.*,g.*,f.* FROM users u LEFT JOIN userstats us ON u.userid=us.userid LEFT JOIN cities c ON u.location=c.cityid LEFT JOIN houses h ON u.maxwill=h.hWILL LEFT JOIN gangs g ON g.gangID=u.gang LEFT JOIN fedjail f ON f.fed_userid=u.userid WHERE u.userid={$_GET['u']}");
if($db->num_rows($q) == 0)
{
print "Sorry, we could not find a user with that ID, check your source.";
}
else
{
$r=$db->fetch_row($q);
if($r['user_level'] == 1) { $userl="Member"; } else if($r['user_level'] == 2) { $userl="Admin"; } else if($r['user_level'] == 6) { $userl="Player Helper"; } else if ($r['user_level'] == 3) { $userl="Secretary"; } else if($r['user_level'] == 0) { $userl="NPC"; } else {$userl="Assistant"; }
$lon=($r['laston'] > 0) ?date('F j, Y g:i:s a',$r['laston']) : "Never";
$sup=date('F j, Y g:i:s a',$r['signedup']);
$ts=$r['strength']+$r['agility']+$r['guard']+$r['labour']+$r['IQ'];
$d="";
if($r['laston'] > 0)
{
$la=time()-$r['laston'];
$unit="seconds";
if($la >= 60)
{
$la=(int) ($la/60);
$unit="minutes";
}
if($la >= 60)
{
$la=(int) ($la/60);
$unit="hours";
if($la >= 24)
{
$la=(int) ($la/24);
$unit="days";
}
}
$str="$la $unit ago";
}
else
{
 $str="--";
}
if($r['last_login'] > 0)
{
$ll=time()-$r['last_login'];
$unit2="seconds";
if($ll >= 60)
{
$ll=(int) ($ll/60);
$unit2="minutes";
}
if($ll >= 60)
{
$ll=(int) ($ll/60);
$unit2="hours";
if($ll >= 24)
{
$ll=(int) ($ll/24);
$unit2="days";
}
}
$str2="$ll $unit2 ago";
}
else
{
 $str2="--";
}

if($r['donatordays']) { $r['username'] = "<font color=red>{$r['username']}</font>";$d="[img=donator.gif]"; }
if($r['laston'] >= time()-15*60) { $on="<font color=green>[b]Online[/b]</font>"; } else { $on="<font color=red>[b]Offline[/b]</font>"; }
print "
<h3>Profile for {$r['username']}</h3>
";
if($r['musicc'] ==On)
{echo "<embed src='{$r['music']}' height='20'>";}
echo "
<table width=100% cellspacing=1 class='table'><tr style='background:gray'><th>General Info</th><th>Personal Info</th>
<th>Display Pic</th></tr>
<table>
<tr>
<tr><td rowspan='1'>";
if($r['personal'] == ON)
{
print "
<div style='position:relative;left:300px;top:0px;'>
[b]Name:[/b] {$r['name']}

[b]Last Name:[/b] {$r['last']}

[b]Age:[/b] {$r['age']}

[b]Aim Of The Game:[/b] {$r['aog']}

[b]MSN:[/b] {$r['msn']}

[b]AIM:[/b] {$r['aim']}

[b]AOL:[/b] {$r['aol']}

[b]Yahoo:[/b] {$r['yahoo']}
";
}
else if($r['personal'] == OFF)
{
print " This Person Dose Not Want To Share There Personal Details";
}
print "
<table cellspacing='1' border='0' cellpadding='3' <tr background='tablegrad.png'><th></table>";
{
}
print "
<tr><td> 

<div style='position:relative;left:-0px;top:-310px;'>
[b]
Name: {$r['username']} [{$r['userid']}] 

User Level: $userl

Duties: {$r['duties']}

Gender: {$r['gender']}

Signed Up: $sup

Last Active: $lon

Last Action: $str

Last Login: $str2

Online: $on

[b]Days Old:[/b] {$r['daysold']} Days Old

Location: {$r['cityname']}</td><td>
<div style='position:relative;left:-165px;top:80px;'>
";

echo "
<table width=100% cellspacing=1 class='table'><tr style='background:gray'><th>Financial Info</th><th>User links</th>
<th>Physical Info</th><th>Staff Notes</th>


<table>
<tr>
<tr><td rowspan='1'>";
print "
<div style='position:relative;left:40px;top:-50px;'>
[b]
Money: \${$r['money']}

Crystals: {$r['crystals']}

Property: {$r['hNAME']}

Referals: ";
$rr=$db->query("SELECT * FROM referals WHERE refREFER={$r['userid']}");
print $db->num_rows($rr);
print "

Friends: {$r['friend_count']}

Enemies: {$r['enemy_count']}
</td> <td>";
if($r['display_pic'])
{
print "
<div style='position:relative;left:479px;top:-220px;'>
[img={$r[]";
}
else
{
print "
<div style='position:relative;left:200px;top:-140px;'>
This user has no display pic!";
}

$sh=($ir['user_level'] >1) ? "Staff Info" : " ";
print "
<tr><td><div style='position:relative;left:324px;top:-310px;'>[b]Level: {$r['level']}

Health: {$r['hp']}/{$r['maxhp']}

gang: ";
if($r['gang'])
{
print "[url='gangs.php?action=view&ID={$r[']{$r['gangNAME']}[/url]";
}
{
print "";
}
if($r['fedjail'])
{
print "
[b]<font color=red>In federal jail for {$r['fed_days']} day(s).

{$r['fed_reason']}</font>";
}
if($r['hospital'])
{
print "
[b]<font color=red>In hospital for {$r['hospital']} minutes.
{$r['hospreason']}</font>[/b]";
}
if($r['jail'])
{
print "
[b]<font color=red>In jail for {$r['jail']} minutes.
{$r['jail_reason']}</font>[/b]";
}
if($r['stds'])
{
print "<font color=yellow>Has A STD</font>
";
}
print "
</td><td><div style='position:relative;left:85px;top:-205px;'>[[url='mailbox.php?action=compose&ID={$r['][b]Send Mail[/url]]

";

$marq=$db->query("SELECT iv.*,i.*,it.* FROM inventory iv LEFT JOIN items i ON iv.inv_itemid=i.itmid LEFT JOIN itemtypes it ON i.itmtype=it.itmtypeid WHERE iv.inv_userid=$userid AND it.itmtypename='$type'");
if($db->num_rows($marq) and $ir['married'] == 0)
{
print "
[[url='propose.php?ID={$r[']Propose[/url]]
";
} 
print "[[url='sendcash.php?ID={$r[']Send Cash[/url]]

";
if($set['sendcrys_on'])
{
print "[[url='sendcrys.php?ID={$r[']Send Crystals[/url]]

";
}
if($set['sendbank_on'])
{
if($ir['bankmoney'] >= 0 && $r['bankmoney'] >= 0)
{
print "[[url='sendbank.php?ID={$r[']Bank Xfer[/url]]

";
}
if($ir['cybermoney'] >= 0 && $r['cybermoney'] >= 0)
{
print "[[url='sendcyber.php?ID={$r[']CyberBank Xfer[/url]]

";
}
}
print "
[[url='attack.php?ID={$r[']Attack[/url]]


[[url='contactlist.php?action=add&ID={$r[']Add Contact[/url]]";
if($ir['user_level'] == 2 || $ir['user_level'] == 3 || $ir['user_level'] == 5)
{
print "


[[url='jailuser.php?userid={$r[']Jail[/url]]


[[url='mailban.php?userid={$r[']MailBan[/url]]";
}
if($ir['donatordays'] > 0)
{
print "


[[url='friendslist.php?action=add&ID={$r[']Add Friends[/url]]


[[url='blacklist.php?action=add&ID={$r[']Add Enemies[/url]]
";
}
print "</td><td>";
if($ir['user_level'] == 2 || $ir['user_level'] == 3 || $ir['user_level'] == 5)
{
 $r['lastiph'][email protected]($r['lastip']);
 $r['lastiph']=checkblank($r['lastiph']);
 $r['lastip_loginh'][email protected]($r['lastip_login']);
 $r['lastip_loginh']=checkblank($r['lastip_loginh']);
 $r['lastip_signuph'][email protected]($r['lastip_signup']);
 $r['lastip_signuph']=checkblank($r['lastip_signuph']);
print "
<div style='position:relative;left:90px;top:0px;'>
<h3>Internet Info</h3><table width='100%' border='0' cellspacing='1' class='table'>
<tr><td></td><td class='h'>IP</td><td class='h'>Hostname</td></tr>
<tr><td class='h'>Last Hit</td><td>$r[lastip]</td><td>$r[lastiph]</td></tr>
<tr><td class='h'>Last Login</td><td>$r[lastip_login]</td><td>$r[lastip_loginh]</td></tr>
<tr><td class='h'>Signup</td><td>$r[lastip_signup]</td><td>$r[lastip_signuph]</td></tr></table>";
print "<form action='staffnotes.php' method='post'>
<div style='position:relative;left:150px;top:-320px;'>
[b]Staff Notes: 

<textarea rows=7 cols=40 name='staffnotes'>{$r['staffnotes']}</textarea>

<input type='hidden' name='ID' value='{$_GET['u']}' />
<input type='submit' value='Change' /></form>";
}
else
{
print " ";
}
print "</tr>";
}
}
function checkblank($in)
{
 if(!$in) { return "N/A"; }
 return $in;
}
print "</td></tr>

";
print "
<table width=100% cellspacing=1 class='table'><tr style='background:gray'><th>Profile Signature</th>
<tr><td rowspan='1'>";
if($r['signature'])
{
print "{$r['signature']}";
}
else
{
print "[b]This User has no Profile Signature[/b]";
}
{
}
print"</table>";
$h->endpage();
?>
Link to comment
Share on other sites

Re: Viewuser problem

 

<table width=100% cellspacing=1 class='table'><tr style='background:gray'><th>General Info</th><th>Personal Info</th>
<th>Display Pic</th></tr>
<table>
<tr>
<tr><td rowspan='1'>";

 

I could be wrong, but having to <tr>'s right next to each other. That's a no no.

 

print "
<table cellspacing='1' border='0' cellpadding='3' <tr background='tablegrad.png'><th></table>";

 

Here you have a <table><tr><th></table> and that's another big no no.

Clearly you've got more than just a simple missing ' or >.

Now the detective work ensues: Who edited/created this file?

If you made it, don't read this next line lol

If you someone made it for you, their html skillz are pretty off point and you should fire them.

But if you did make this file, clearly you need to study up on your html a bit.

I suggest looking at the view source, and to do so with firefox since it has a quasi html highlighter. Opera does as well. IE simply uses notepad, hence IE's view source sucks bad.

If someone coded this for you, you should get them to fix it, or get a refund. If not, You'll likely want to hire someone to look over that code. I don't want to do it though, as you might think I'm just trying to sell you on something. Seriously, as fugged up as that html is, there's no tellin how bad the rest of it is fugged up....

Link to comment
Share on other sites

Guest Anonymous

Re: Viewuser problem

Slightly OT ...

two or more <TR>'s next to each other is permissible albeit unusual.

Assume:

<table><tr><tr><td>text</td></table>

That simple gets rendered as:

<table><tr></tr><tr><td>text</td></tr></table>

However -- it is considered poor practice

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

 Share

×
×
  • Create New...