HauntedDawg Posted September 19, 2013 Share Posted September 19, 2013 On the login/register forms, when focused on a text input, and start typing. The auto-suggest pop's up from previous input text. When selecting text, i hit enter to select it (when imposingly should use tab to move to next input). However, due to the nature of the JS on the page, it submits the login/register form. Thus resulting in getting locked out if done more than 3 times. Thanks. Quote Link to comment Share on other sites More sharing options...
a_bertrand Posted September 19, 2013 Share Posted September 19, 2013 So what's your suggestion? Quote Link to comment Share on other sites More sharing options...
HauntedDawg Posted September 20, 2013 Author Share Posted September 20, 2013 So what's your suggestion? If focused on a text input, and enter is pressed, ignore the rest. It's your engine. Not mine, I'm just pointing out a bug. So how you fix it, is not up to me. Quote Link to comment Share on other sites More sharing options...
a_bertrand Posted September 20, 2013 Share Posted September 20, 2013 So what you propose it to avoid browser auto-completion? And even if it is my engine, you are the user, you should propose ;-) Quote Link to comment Share on other sites More sharing options...
DeathsAlive Posted September 20, 2013 Share Posted September 20, 2013 If focused on a text input, and enter is pressed, ignore the rest. It's your engine. Not mine, I'm just pointing out a bug. So how you fix it, is not up to me. http://www.w3schools.com/tags/att_input_autocomplete.asp autocomplete="off". Simples :) Quote Link to comment Share on other sites More sharing options...
Blade Maker Posted September 20, 2013 Share Posted September 20, 2013 So what you propose it to avoid browser auto-completion? And even if it is my engine, you are the user, you should propose ;-) Don't forms submit on [enter] already? If that's the case why would JS be needed to submit on enter? Unless I'm missing something, an idea is maybe to only check on the last text input for an [enter] press, that way it will select from auto suggest (if user decides to) and submit after all their data is put in. Quote Link to comment Share on other sites More sharing options...
a_bertrand Posted September 20, 2013 Share Posted September 20, 2013 Personally I hardly see it as a bug, as if you use the tab key, the auto-suggest will pick the value. If you don't want auto-suggest then as DeathAlives says you disable it. On the other side if you want to disable the enter to submit, simply remove the file auto_post_public.php found in the login module. For me it's a question of taste of the game owner and what he want to do. Quote Link to comment Share on other sites More sharing options...
HauntedDawg Posted September 20, 2013 Author Share Posted September 20, 2013 So what you propose it to avoid browser auto-completion? And even if it is my engine, you are the user, you should propose ;-) No, I do not propose to avoid browser auto-completion. http://www.w3schools.com/tags/att_input_autocomplete.asp autocomplete="off". Simples :) No, the point is not regarding autocomplete behaviour, but the fact that the JS is not doing a proper check to see if an element is still focused. Personally I hardly see it as a bug, as if you use the tab key, the auto-suggest will pick the value. If you don't want auto-suggest then as DeathAlives says you disable it. On the other side if you want to disable the enter to submit, simply remove the file auto_post_public.php found in the login module. For me it's a question of taste of the game owner and what he want to do. Since I was using the internet, I always press enter to choose an auto-suggest. Funny you don't see it as a bug, but no other website that I use apart from NW-Engine does this? Now let's look at it like this. I have a field, that i start typing ky, it then gives me a list of kyle, kyle02, kyle1 and so forth. A username i use quite often, is kyle0217. Now if I hit enter, i stay focused on the element, so as if I were to choose kyle02, hit enter and type 17, then i get a 3 trials left before being locked message. But your right. It's not a bug..duly note the sarcasm... meh, don't know why i even bother. Quote Link to comment Share on other sites More sharing options...
a_bertrand Posted September 20, 2013 Share Posted September 20, 2013 The script does nothing else than adding a onkeypress event to the input fields. Which means if they would not be on focus, the script wouldn't be called. Therefore I hardly see how I can check if you are in the auto-completion or not... As said, you should decide what you want to do with your installation. You don't like the script? You remove it from the login module... it's one file to delete. Quote Link to comment Share on other sites More sharing options...
HauntedDawg Posted September 20, 2013 Author Share Posted September 20, 2013 The script does nothing else than adding a onkeypress event to the input fields. Which means if they would not be on focus, the script wouldn't be called. Therefore I hardly see how I can check if you are in the auto-completion or not... As said, you should decide what you want to do with your installation. You don't like the script? You remove it from the login module... it's one file to delete. I myself checked to see if it can be done with the default browser auto complete behavior. While there are some possible fixes, non of them worked. But instead of saying "I dont see it as a bug" (when infact it kind of is), could of just said directly that it can be disabled. Thanks anyway. - - - Updated - - - Closed. ~ TOO SHORT ~ Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.