Problem with making crimes

[Strats]

I made two crimes the other day and then today I tried to make some more.

I changed the Success % Formula from

((WILL*0.8)/2.5)+(LEVEL/4) so something like ((WILL*0.8)/2.5)+(LEVEL/6)

Just trying to make it a little harder for the next crime.

Well I guess I am doing something wrong because I got this message after I clicked create crime.

QUERY ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ' 0, '2',

Can anyone help me out a bit please?

Maybe explain how to create crimes, this was my first try lol

[XCU53S]

Re: Problem with making crimes

Im no genius but im guessing you need to look in your staff_crimes.php there must be a problem with the query that inserts the crime into the database. If you cant fix i suggest just adding crimes via phpmyadmin much quicker and ewasier hope i helped :-D

[Strats]

Re: Problem with making crimes

I will have to have a try

thanks for your help :-)

[Strats]

Re: Problem with making crimes

I have had a look at doing it through the database and I may try it.

But my crimes will bother me if I don't know why I can't make any lol.

Can someone take a look at this to see if there's anything wrong with it please.

 

<?php
include "sglobals.php";
if($ir['user_level'] > 2)
{
die("403");
}
//This contains course stuffs
switch($_GET['action'])
{
case 'newcrime': new_crime_form(); break;
case 'newcrimesub': new_crime_submit(); break; 
case 'editcrime': edit_crime_begin(); break;
case 'editcrimeform': edit_crime_form(); break;
case 'editcrimesub': edit_crime_sub(); break;
case 'delcrime': delcrime(); break; 
case 'newcrimegroup': new_crimegroup_form(); break;
case 'newcrimegroupsub': new_crimegroup_submit(); break;
case 'editcrimegroup': edit_crimegroup_begin(); break;
case 'editcrimegroupform': edit_crimegroup_form(); break;
case 'editcrimegroupsub': edit_crimegroup_sub(); break;
case 'delcrimegroup': delcrimegroup(); break;
case 'reorder': reorder_crimegroups(); break;
default: print "Error: This script requires an action."; break;
}
function new_crime_form()
{
global $ir, $c, $db;
print "Adding a new crime.

<form action='staff_crimes.php?action=newcrimesub' method='post'>
Name: <input type='text' name='name' />

Brave Cost: <input type='text' name='brave' />

Success % Formula: <input type='text' name='percform' value='((WILL*0.8)/2.5)+(LEVEL/4)' />

Success Money: <input type='text' name='money' />

Success Crystals: <input type='text' name='crys' />

Success Item: ".item2_dropdown($c, 'item')."

Group: ".crimegroup_dropdown($c,'group')."

Initial Text: <textarea rows=4 cols=40 name='itext'  /></textarea>

Success Text: <textarea rows=4 cols=40 name='stext' /></textarea>

Failure Text: <textarea rows=4 cols=40 name='ftext' /></textarea>

Jail Text: <textarea rows=4 cols=40 name='jtext' /></textarea>

Jail Time: <input type='text' name='jailtime' />

Jail Reason: <input type='text' name='jailreason' />

Crime XP Given: <input type='text' name='crimexp' />

<input type='submit' value='Create Crime' /></form>";
}
function new_crime_submit()
{
global $ir,$c,$userid, $db;
if($_POST['itemon'] != "on") { $_POST['item']=0; }
$db->query("INSERT INTO crimes (crimeNAME, crimeBRAVE, crimePERCFORM, crimeSUCCESSMUNY, crimeSUCCESSCRYS, crimeSUCCESSITEM, crimeGROUP, crimeITEXT, crimeSTEXT, crimeFTEXT, crimeJTEXT, crimeJAILTIME, crimeJREASON, crimeXP) VALUES( '{$_POST['name']}', '{$_POST['brave']}', '{$_POST['percform']}', '{$_POST['money']}', {$_POST['crys']}, {$_POST['item']}, '{$_POST['group']}', '{$_POST['itext']}', '{$_POST['stext']}', '{$_POST['ftext']}', '{$_POST['jtext']}', {$_POST['jailtime']}, '{$_POST['jailreason']}', {$_POST['crimexp']})");
print "Crime created!";
stafflog_add("Created crime {$_POST['name']}");
} 
function edit_crime_begin()
{
global $ir,$c,$h,$userid,$db;
print "<h3>Editing Crime</h3>
You can edit any aspect of this crime. 

<form action='staff_crimes.php?action=editcrimeform' method='post'>
Crime: ".crime_dropdown($c,'crime')."

<input type='submit' value='Edit Crime' /></form>";
}
function edit_crime_form()
{
global $ir,$c,$h,$userid,$db;

$d=$db->query("SELECT * FROM crimes WHERE crimeID={$_POST['crime']}");
$itemi=$db->fetch_row($d);
print "<h3>Editing Crime</h3>
<form action='staff_crimes.php?action=editcrimesub' method='post'>
<input type='hidden' name='crimeID' value='{$_POST['crime']}' />

Name: <input type='text' name='crimeNAME' value='{$itemi['crimeNAME']}' />

Brave Cost: <input type='text' name='crimeBRAVE' value='{$itemi['crimeBRAVE']}' />

Success % Formula: <input type='text' name='crimePERCFORM' value='{$itemi['crimePERCFORM']}' />

Success Money: <input type='text' name='crimeSUCCESSMUNY' value='{$itemi['crimeSUCCESSMUNY']}' />

Success Crystals: <input type='text' name='crimeSUCCESSCRYS' value='{$itemi['crimeSUCCESSCRYS']}' />

Success Item: ".item2_dropdown($c, 'crimeSUCCESSITEM', $itemi['crimeSUCCESSITEM'])."

Group: ".crimegroup_dropdown($c,'crimeGROUP', $itemi['crimeGROUP'])."

Initial Text: <textarea rows=4 cols=40 name='crimeITEXT'  />{$itemi['crimeITEXT']}'</textarea>

Success Text: <textarea rows=4 cols=40 name='crimeSTEXT' />{$itemi['crimeSTEXT']}</textarea>

Failure Text: <textarea rows=4 cols=40 name='crimeFTEXT' />{$itemi['crimeFTEXT']} </textarea>

Jail Text: <textarea rows=4 cols=40 name='crimeJTEXT' />{$itemi['crimeJTEXT']} </textarea>

Jail Time: <input type='text' name='crimeJAILTIME' value='{$itemi['crimeJAILTIME']}' />

Jail Reason: <input type='text' name='crimeJREASON' value='{$itemi['crimeJREASON']}' />

Crime XP Given: <input type='text' name='crimeXP' value='{$itemi['crimeXP']}' />

<input type='submit' value='Edit Crime' /></form>";
}
function edit_crime_sub()
{
global $ir,$c,$h,$userid, $db;
$db->query("UPDATE crimes SET  crimeNAME='{$_POST['crimeNAME']}', crimeBRAVE='{$_POST['crimeBRAVE']}', crimePERCFORM='{$_POST['crimePERCFORM']}', crimeSUCCESSMUNY='{$_POST['crimeSUCCESSMUNY']}', 
crimeSUCCESSCRYS='{$_POST['crimeSUCCESSCRYS']}', 
crimeSUCCESSITEM='{$_POST['crimeSUCCESSITEM']}', crimeGROUP='{$_POST['crimeGROUP']}', crimeITEXT='{$_POST['crimeITEXT']}', crimeSTEXT='{$_POST['crimeSTEXT']}', crimeFTEXT='{$_POST['crimeFTEXT']}', crimeJTEXT='{$_POST['crimeJTEXT']}', crimeJAILTIME={$_POST['crimeJAILTIME']}, crimeJREASON='{$_POST['crimeJREASON']}', crimeXP={$_POST['crimeXP']} WHERE crimeID={$_POST['crimeID']}");
print "Crime edited...";
stafflog_add("Edited crime {$_POST['crimeNAME']}");

} 
function delcrime()
{
global $ir,$c,$h,$userid, $db;
switch ($_GET['step'])
{
  default:
     echo "<h3>Deleting Crime</h3>
     Here you can delete a crime. 

     <form action='staff_crimes.php?action=delcrime&step=2' method='post'>
     Crime: ".crime_dropdown($c,'crime')."

     <input type='submit' value='Delete Crime' /></form>";
  break;
  case 2:
     $target = $_POST['crime'];
     $d=$db->query("SELECT crimeNAME FROM crimes WHERE crimeID='$target'");
     $itemi=$db->fetch_row($d);
     print "<h3>Confirm</h3>
     Delete crime -  ".$itemi["crimeNAME"]."?
     <form action='staff_crimes.php?action=delcrime&step=3' method='post'>
     <input type='hidden' name='crimeID' value='$target' />
     <input type='submit' name='yesorno' value='Yes' />
     <input type='submit' name='yesorno' value='No' onclick=\"window.location='staff_crimes.php?action=delcrime';\" /></form>";
  break;
  case 3:
     $target = $_POST['crimeID'];
     if($_POST['yesorno']=='No')
     {
        die("Crime not deleted.
[url='staff_crimes.php?action=delcrime']>Back to main delete crimes page.[/url]");
     }
     if ($_POST['yesorno'] != ("No" || "Yes")) die('Eh');
     $d=$db->query("SELECT crimeNAME FROM crimes WHERE crimeID='$target'");
     $itemi=$db->fetch_row($d);
     $db->query("DELETE FROM crimes WHERE crimeID='$target'");
     echo "Crime {$itemi['crimeNAME']} Deleted.
[url='staff_crimes.php?action=delcrime']>Back to main delete crimes page.[/url]"; 
stafflog_add("Deleted crime {$itemi['crimeNAME']}");    
  break;
}
} 
function new_crimegroup_form()
{
global $ir, $c,$db;
print "Adding a new crime group.

<form action='staff_crimes.php?action=newcrimegroupsub' method='post'>
Name: <input type='text' name='cgNAME' />

Order Number: <input type='text' name='cgORDER' />

<input type='submit' value='Create Crime Group' /></form>";
}
function new_crimegroup_submit()
{
global $ir,$c,$userid,$db;
if(!isset($_POST['cgNAME']) || !isset($_POST['cgORDER']))
{
print "You missed one or more of the required fields. Please go back and try again.

[url='staff_crimes.php?action=newcrimegroup']> Back[/url]";
$h->endpage();
exit;
}
$db->query("INSERT INTO `crimegroups` (`cgNAME`, `cgORDER`) VALUES('{$_POST['cgNAME']}','{$_POST['cgORDER']}')");
print "Crime Group created!";
stafflog_add("Created Crime Group {$_POST['cgNAME']}");
}

function edit_crimegroup_begin()
{
global $ir,$c,$h,$userid,$db;
print "<h3>Editing A Crime Group</h3>
<form action='staff_crimes.php?action=editcrimegroupform' method='post'>
Crime Group: ".crimegroup_dropdown($c,'crimeGROUP')."

<input type='submit' value='Edit Crime Group' /></form>";
}

function edit_crimegroup_form()
{
global $ir,$c,$h,$userid,$db;

$d=$db->query("SELECT * FROM crimegroups WHERE cgID={$_POST['crimeGROUP']}");
$itemi=$db->fetch_row($d);
print "<h3>Editing Crime Group</h3>
<form action='staff_crimes.php?action=editcrimegroupsub' method='post'>
<input type='hidden' name='cgID' value='{$_POST['crimeGROUP']}' />
Name: <input type='text' name='cgNAME' value='{$itemi['cgNAME']}' />

Order Number: <input type='text' name='cgORDER' value='{$itemi['cgORDER']}' />

<input type='submit' value='Edit Crime Group' /></form>";
}

function edit_crimegroup_sub()
{
global $ir,$c,$h,$userid, $db;
if(!isset($_POST['cgORDER']) || !isset($_POST['cgNAME']))
{
print "You missed one or more of the required fields. Please go back and try again.

[url='staff_crimes.php?action=editcrimegroup']> Back[/url]";
$h->endpage();
exit;
}
else
{
$db->query("UPDATE crimegroups SET  cgNAME='{$_POST['cgNAME']}', cgORDER='{$_POST['cgORDER']}' WHERE cgID='{$_POST['cgID']}'");
print "Crime Group edited...";
stafflog_add("Edited Crime Group {$_POST['cgNAME']}");
}
}

function delcrimegroup()
{
global $ir,$c,$h,$userid, $db;
switch ($_GET['step'])
{
  default:
     echo "<h3>Deleting Crime Group</h3>
<script type='text/javascript'>
function checkme()
{
if(document.theform.crimeGROUP.value==document.theform.crimeGROUP2.value)
{
alert('You cannot select the same crime group to move the crimes to.');
return false;
}
return true;
}
</script>
     <form action='staff_crimes.php?action=delcrimegroup&step=2' method='post' name='theform' onsubmit='return checkme();'>
     Crime Group: ".crimegroup_dropdown($c,'crimeGROUP')."

Move crimes in deleted group to: ".crimegroup_dropdown($c, 'crimeGROUP2')."

     <input type='submit' value='Delete Crime Group' /></form>";
  break;
  case 2:
     $target = $_POST['crimeGROUP'];
$target2 = $_POST['crimeGROUP2'];
if($target==$target2) { die("You cannot select the same crime group to move the crimes to."); }
     $d=$db->query("SELECT cgNAME FROM crimegroups WHERE cgID='$target'");
     $itemi=$db->fetch_row($d);
     print "<h3>Confirm</h3>
     Delete crime group -  ".$itemi["cgNAME"]."?
     <form action='staff_crimes.php?action=delcrimegroup&step=3' method='post'>
     <input type='hidden' name='cgID' value='$target' />
<input type='hidden' name='cgID2' value='$target2' />
     <input type='submit' name='yesorno' value='Yes' />
     <input type='submit' name='yesorno' value='No' onclick=\"window.location='staff_crimes.php?action=delcrimegroup';\" /></form>";
  break;
  case 3:
     $target = $_POST['cgID'];
$target2 = $_POST['cgID2'];
     if($_POST['yesorno']=='No')
     {
        die("Crime Group not deleted.");
     }
     if ($_POST['yesorno'] != ("No" || "Yes")) die('This shouldnt happen');
     $d=$db->query("SELECT cgNAME FROM crimegroups WHERE cgID='$target'");
     $itemi=$db->fetch_row($d);
     $db->query("DELETE FROM crimegroups WHERE cgID='{$_POST['cgID']}'");
$db->query("UPDATE crimes SET crimeGROUP={$target2} WHERE crimeGROUP={$target}");
stafflog_add("Deleted crime group {$itemi['cgNAME']}");
     echo "Crime Group deleted.";     
  break;
}
}
function reorder_crimegroups()
{
global $db,$ir,$c,$h,$userid;
if($_POST['submit'])
{
unset($_POST['submit']);
$used=array();
foreach($_POST as $v)
{
if(in_array($v, $used))
{
print "You have used the same order number twice! Go back and try again.";
$h->endpage();
exit;
}
$used[]=$v;
}
foreach($_POST as $k => $v)
{
$cg=str_replace("order","", $k);
if(is_numeric($cg))
{
$db->query("UPDATE crimegroups SET cgORDER={$v} WHERE cgID={$cg}");
}
}
print "Crime group order updated!";
stafflog_add("Reordered crime groups");
}
else
{
$q=$db->query("SELECT * FROM crimegroups ORDER BY cgORDER ASC, cgID ASC");
$rows=$db->num_rows($q);
$i=0;
print "<h3>Re-ordering Crime Groups</h3><hr />
<table width='80%' cellspacing='1' class='table'>
<tr>
<th>Crime Group</th>
<th>Order</th>
</tr>
<form action='staff_crimes.php?action=reorder' method='post'>
<input type='hidden' name='submit' value='1' />";
while($r=$db->fetch_row($q))
{
$i++;
print "<tr>
<td>{$r['cgNAME']}</td>
<td><select name='order{$r['cgID']}' type='dropdown'>";
for($j=1;$j<=$rows;$j++)
{
if($j == $i)
{
print "<option value='{$j}' selected='selected'>{$j}</option>";
}
else
{
print "<option value='{$j}'>{$j}</option>";
}
}
print "</select></td></tr>";
}
print "<tr>
<td colspan='2' align='center'><input type='submit' value='Reorder' /></td>
</tr></form></table>";
}
}
function report_clear()
{
global $db,$ir,$c,$h,$userid;
if($ir['user_level'] > 3)
{
die("403");
}
$_GET['ID'] = abs((int) $_GET['ID']);
stafflog_add("Cleared player report ID {$_GET['ID']}");
$db->query("DELETE FROM preports WHERE prID={$_GET['ID']}");
print "Report cleared and deleted!

[url='staff_users.php?action=reportsview']> Back[/url]";
}
$h->endpage();
?>

 

If nothing is wrong then it's just my bad luck I guess lol

[doinkinator]

Re: Problem with making crimes

i AM HAVING THE SAME ERROR IF YOU HAVE RECIEVE A RESOLUTION PLEASE EMAIL ME I CANT FIGURE IT OUT

[(((TOLK)))]

Re: Problem with making crimes

I used to get an error on crimes, not too sure wot it used to say but i think it's because i didnt fill everything in, so try to fill everything in and see what happens

[Faz`]

Re: Problem with making crimes

Yup TOLK is right. I made a crime on your game whilst I was admin. Eg if you don't want any crime XP to be gained. Fill in 0, don't leave it blank.

[Strats]

Re: Problem with making crimes

I know you did.

I have kinda sorted my crimes out a bit more now.

I kinda just needed to see someones admin staff panel to see what they should look like.

I was trying to make crimes for like level 10 and so on but they didn't work for level 10's lol

I have a kinda template to work from now tho

[doinkinator]

Re: Problem with making crimes

Ok i figured it out there was a missing value i was forgetting to put crystal = but i fixed it ummm i still have a issue of creating cities though no error message just no city is created

[Strats]

Re: Problem with making crimes

You should send me a private message with your game.

I will have a look at it if you want.

[(((TOLK)))]

Re: Problem with making crimes

The code for create a city on Mccodes V2 does't work, so you could do it through phpMyAdmin. I might have a look at it and create a fix for it :-)

[Strats]

Re: Problem with making crimes

Works for me, well has I have only made 2 cities so far lol

[(((TOLK)))]

Re: Problem with making crimes

ok here's the fix

open staff_cities.php

Find:

Minimum Level: <input type='text' name=minlevel' />

 

It's on line 40

 

Replace it with:

 

Minimum Level: <input type='text' name='minlevel' />

 

A (') had been missed out all it does is adds the (')