can some one please help

[skizzy]

im currently working on a new game and i can't seem to get this code to update a field in my db. can some please help me with this

<?php
session_start();
require "global_func.php";
if($_SESSION['loggedin']==0) { header("Location: login.php");exit; }
$userid=$_SESSION['userid'];
require "header.php";
$h = new headers;
$h->startheaders();
include "mysql.php";
global $c;
$is=mysql_query("SELECT u.*,us.* FROM users u LEFT JOIN userstats us ON u.userid=us.userid WHERE u.userid=$userid",$c) or die(mysql_error());
$ir=mysql_fetch_array($is);
check_level();
$fm=money_formatter($ir['money']);

$gip=make_ip();

function make_ip(){
$inum1 = rand(0,255);
$inum2 = rand(0,255);
$inum3 = rand(0,255);
$inum4 = rand(0,255);
$ip = $inum1.'.'.$inum2.'.'.$inum3.'.'.$inum4;
return $ip;	
}

echo "Ip set to"; echo make_ip();
mysql_query("UPDATE users set Gameip=$gip WHERE userid=$userid",$c);
?> 

[Danny696]

whats the error?

Have you added Gameip to the users table?

[skizzy]

there is no error and i added it to the table as it shows the ip my header but wontupdate the ip with the new the generated ip

for the game im making

[Danny696]

change

mysql_query("UPDATE users set Gameip=$gip WHERE userid=$userid",$c);

To this:

mysql_query("UPDATE `users` SET `Gameip` = ", $gip ," WHERE (`userid` = ". $userid .");",$c) or die(mysql_error());

Then see if it displays an error, and post back :)

[skizzy]

here is the error i get after changing that Warning: mysql_query() expects at most 2 parameters, 4 given in C:\xampp\htdocs\ip.php on line 28

[Danny696]

My bad,

try this:

 

mysql_query("UPDATE `users` SET `Gameip` = ". $gip ." WHERE (`userid` = ". $userid .");",$c) or die(mysql_error());

[skizzy]

here is the error i get now Ip set to131.16.117.95You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '.141.211 WHERE (`userid` = 1)' at line 1

[Lithium]

the original code ought to work... unless table is gameip (which i believe it is) and you are calling Gameip...

Tables are case sensitive in most cases...

also one minor detail...

echo "Ip set to"; echo make_ip();

you are echoing one fake IP that ought to be set off though you already had one...

so the correct line there ought to be...

echo "Ip set to ".$gip;

[skizzy]

well now i dont get any error but still wont update the db and the field GameIP is Correct

<?php
session_start();
require "global_func.php";
if($_SESSION['loggedin']==0) { header("Location: login.php");exit; }
$userid=$_SESSION['userid'];
require "header.php";
$h = new headers;
$h->startheaders();
include "mysql.php";
global $c;
$is=mysql_query("SELECT u.*,us.* FROM users u LEFT JOIN userstats us ON  u.userid=us.userid WHERE u.userid=$userid",$c) or die(mysql_error());
$ir=mysql_fetch_array($is);
check_level();
$fm=money_formatter($ir['money']);

$gip=make_ip();

function make_ip(){
	$inum1 = rand(0,255);
	$inum2 = rand(0,255);
	$inum3 = rand(0,255);
	$inum4 = rand(0,255);
	$ip = $inum1.'.'.$inum2.'.'.$inum3.'.'.$inum4;
	return $ip;    
}



echo "Ip set to ".$gip;
mysql_query("UPDATE users set GameIP=$gip WHERE userid=$userid",$c);
?> 

[Lithium]

hmmm... GameIP field type is... INT? if it is... there lays your problem.

change it to VARCHAR(15) and you might have your issue solved...

[skizzy]

already is been since i made the field

[Danny696]

I know,

change the old query to this one:

ysql_query("UPDATE `users` SET `Gameip` = '". $gip ."' WHERE (`userid` = ". $userid .");",$c) or die(mysql_error());

[skizzy]

thank you danny that worked great

[Lithium]

@Danny: your query is exactly the same (yet tidier) so it won't make a a difference.

[Danny696]

is it -.- Notice the ' and ' kthxbi