PHP code help

[General Doom]

Hello all.

 

Im trying to create a PHP code that updates all users money every hour based on there income.

Im doing this using a crontab so that it runs on exactly every hour.

 

However, every users current money and income is different, so, is there a way to get the mySQL to cycle through every user without having to run the script for multiple users?

 

The surrent script im using only does it for the 1st player registered (me), any ideas?

 

 

<?php
$playerid=mysql_query("SELECT * FROM users");
$user=mysql_fetch_object($playerid);
$newcreds=$user->credits+$user->economy;
$userid=$user->id;
mysql_query("UPDATE users SET credits='$newcreds' WHERE id='$userid'");
?>

 

 

Any ideas on how I can get it to do this for every user?

[Danny696]

Use a while loop

[General Doom]

Can't believe I didn't think of that. Thankyou very much!

[CrazyT]

Watch out how you use that while loop, say if you have 200 members on the while loop you will be running 200 queries. :)

[Zeggy]

Try this instead:

<?php

mysql_query("UPDATE users SET credits=credits+economy");

?>

[Zero-Affect]

but for example you have a load of members you need to update but they have nothing in common you could do something like

 

          # If your wanting to use an array it's a little different
/*          $mem_array = array(1,3,6,8,9,12,172,1829,2991);
         $mem_val = '';
         $mem_cnt = 1;
foreach ( $mem_array as $value ) {
         $mem_val .= $value.''.(($mem_cnt < count($mem_array)) ? ',' : '' ).'';
         $mem_cnt++;
}
         $members = $mem_val;*/
         # End array method
         $members = '1,3,6,8,9,12,172,1829,2991';
         $updated_creds = 100;
    mysql_query('UPDATE `members` SET `credits` = `credits` + '.$updated_creds.' WHERE `id` IN('.$members.')');

[General Doom]

Thanks for the reply's everyone, in the end I used zeggys simple script and it worked a treat for all my members!

Thanks for the help.

[Zero-Affect]

Your welcome pal, sorry if my solution was confusing.

[General Doom]

Yeach cheers, wasn't confusing as such, just seemed more efficient to do it the other way.

[Zero-Affect]

Yeah it was if your updating all members i was making a example of if you wanted to only update specific users which had nothing in the db in common.

for example

    $num_what = 0;
    $array_peeps = array(1,3,54,68,99,192);
foreach ($arr as $val) {
    mysql_query('UPDATE `users` SET `money` = `money` + 100 WHERE `userid` = '.$val);
}
          # INSTEAD DO:
    mysql_query('UPDATE `users` SET `money` = `money` + 100 WHERE `userid` IN('.$array_peeps.')');